From 4fb58de1a0fdaca622706baa740524b074e33231 Mon Sep 17 00:00:00 2001
From: ZhenYi <434836402@qq.com>
Date: Fri, 24 Apr 2026 13:21:55 +0800
Subject: [PATCH] chore(rpc): remove metrics-related RPC endpoints

- Drop GetMetrics and ExportMetricsCsv from proto, build.rs, client
- These endpoints are no longer needed in the admin gRPC service
---
 libs/rpc/admin/client.rs   | 27 ---------------------------
 libs/rpc/build.rs          | 18 ------------------
 libs/rpc/proto/admin.proto | 30 ------------------------------
 3 files changed, 75 deletions(-)

diff --git a/libs/rpc/admin/client.rs b/libs/rpc/admin/client.rs
index a64e179..82de891 100644
--- a/libs/rpc/admin/client.rs
+++ b/libs/rpc/admin/client.rs
@@ -9,8 +9,6 @@ use super::generated::admin::{
     KickUserFromWorkspaceRequest, KickUserRequest,
     GetUserStatusRequest, GetUserInfoRequest,
     GetWorkspaceOnlineUsersRequest, IsUserOnlineRequest,
-    GetMetricsRequest, ExportMetricsCsvRequest,
-    InstanceMetrics,
 };
 use super::generated::admin_session_admin::session_admin_client::SessionAdminClient;
 use super::types::from_proto_status;
@@ -135,31 +133,6 @@ impl AdminGrpcClient {
             .map_err(|e| anyhow::anyhow!("gRPC error: {}", e))?;
         Ok(res.into_inner().online)
     }
-
-    /// Query metrics across all app instances.
-    pub async fn get_metrics(
-        &mut self,
-        instance_filter: &str,
-        limit: u32,
-    ) -> anyhow::Result<Vec<InstanceMetrics>> {
-        let req = tonic::Request::new(GetMetricsRequest {
-            instance_filter: instance_filter.to_string(),
-            limit,
-        });
-        let res = self.inner.get_metrics(req).await
-            .map_err(|e| anyhow::anyhow!("gRPC error: {}", e))?;
-        Ok(res.into_inner().instances)
-    }
-
-    /// Export all metrics as CSV string.
-    pub async fn export_metrics_csv(&mut self, instance_filter: &str) -> anyhow::Result<String> {
-        let req = tonic::Request::new(ExportMetricsCsvRequest {
-            instance_filter: instance_filter.to_string(),
-        });
-        let res = self.inner.export_metrics_csv(req).await
-            .map_err(|e| anyhow::anyhow!("gRPC error: {}", e))?;
-        Ok(res.into_inner().csv)
-    }
 }
 
 // ---------------------------------------------------------------------------
diff --git a/libs/rpc/build.rs b/libs/rpc/build.rs
index bd8abdf..f614842 100644
--- a/libs/rpc/build.rs
+++ b/libs/rpc/build.rs
@@ -82,24 +82,6 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
                 .codec_path("tonic_prost::ProstCodec")
                 .build(),
         )
-        .method(
-            tonic_prost_build::manual::Method::builder()
-                .name("get_metrics")
-                .route_name("GetMetrics")
-                .input_type("crate::admin::generated::admin::GetMetricsRequest")
-                .output_type("crate::admin::generated::admin::GetMetricsResponse")
-                .codec_path("tonic_prost::ProstCodec")
-                .build(),
-        )
-        .method(
-            tonic_prost_build::manual::Method::builder()
-                .name("export_metrics_csv")
-                .route_name("ExportMetricsCsv")
-                .input_type("crate::admin::generated::admin::ExportMetricsCsvRequest")
-                .output_type("crate::admin::generated::admin::ExportMetricsCsvResponse")
-                .codec_path("tonic_prost::ProstCodec")
-                .build(),
-        )
         .build();
 
     tonic_prost_build::manual::Builder::new()
diff --git a/libs/rpc/proto/admin.proto b/libs/rpc/proto/admin.proto
index ea1caad..6cad207 100644
--- a/libs/rpc/proto/admin.proto
+++ b/libs/rpc/proto/admin.proto
@@ -93,34 +93,6 @@ message IsUserOnlineResponse {
   bool online = 1;
 }
 
-// ---------------------------------------------------------------------------
-// Metrics
-// ---------------------------------------------------------------------------
-
-message GetMetricsRequest {
-  string instance_filter = 1;   // filter by instance_id substring
-  uint32 limit = 2;             // max snapshots per instance (default 100)
-}
-message GetMetricsResponse {
-  repeated InstanceMetrics instances = 1;
-}
-
-message InstanceMetrics {
-  string instance_id = 1;
-  int64 timestamp_secs = 2;
-  // HTTP metrics, key = metric name, value = JSON value
-  map<string, string> http = 3;
-  // Room/room metrics
-  map<string, string> room = 4;
-}
-
-message ExportMetricsCsvRequest {
-  string instance_filter = 1;
-}
-message ExportMetricsCsvResponse {
-  string csv = 1;
-}
-
 // ---------------------------------------------------------------------------
 // AI Model Sync
 // ---------------------------------------------------------------------------
@@ -226,8 +198,6 @@ service SessionAdmin {
   rpc GetUserInfo(GetUserInfoRequest) returns (GetUserInfoResponse);
   rpc GetWorkspaceOnlineUsers(GetWorkspaceOnlineUsersRequest) returns (GetWorkspaceOnlineUsersResponse);
   rpc IsUserOnline(IsUserOnlineRequest) returns (IsUserOnlineResponse);
-  rpc GetMetrics(GetMetricsRequest) returns (GetMetricsResponse);
-  rpc ExportMetricsCsv(ExportMetricsCsvRequest) returns (ExportMetricsCsvResponse);
   // AI
   rpc SyncModels(SyncModelsRequest) returns (SyncModelsResponse);
   rpc CheckAlerts(CheckAlertsRequest) returns (CheckAlertsResponse);