ZhenYi/gitdataai
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(frontend): update search API types and fix IMEditor stale closure

Browse Source 
Add room/pn search params to SearchMessagesData type definition.
Fix stale closure issue in IMEditor useEditor's onUpdate callback.
This commit is contained in:
ZhenYi 2026-04-28 13:12:42 +08:00
parent 5a90a475a4
commit a34cd73fdf
2 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/client/types.gen.ts
View File

@ -17765,6 +17765,14 @@ export type SearchMessagesData = {
* Results per page, default 20, max 100 * Results per page, default 20, max 100
*/ */
per_page?: number; per_page?: number;
/**
* Scope search to a specific room by UUID
*/
room?: string;
/**
* Scope search to a specific project by name
*/
pn?: string;
}; };
url: '/api/search/messages'; url: '/api/search/messages';
}; };

14
src/components/room/message/editor/IMEditor.tsx
View File

@ -366,6 +366,14 @@ export const IMEditor = forwardRef<IMEditorHandle, IMEditorProps>(function IMEdi
const slashPool = useMemo(() => [...mentionItems.commands], [mentionItems.commands]); const slashPool = useMemo(() => [...mentionItems.commands], [mentionItems.commands]);
// Refs to avoid stale closure in useEditor's onUpdate
const atPoolRef = useRef(atPool);
const hashPoolRef = useRef(hashPool);
const slashPoolRef = useRef(slashPool);
useEffect(() => { atPoolRef.current = atPool; }, [atPool]);
useEffect(() => { hashPoolRef.current = hashPool; }, [hashPool]);
useEffect(() => { slashPoolRef.current = slashPool; }, [slashPool]);
const selectMention = useCallback((item: MentionItem) => { const selectMention = useCallback((item: MentionItem) => {
const editor = editorRef.current; const editor = editorRef.current;
if (!editor) return; if (!editor) return;
@ -518,7 +526,7 @@ export const IMEditor = forwardRef<IMEditorHandle, IMEditorProps>(function IMEdi
const q = text.slice(ts - 1, from); const q = text.slice(ts - 1, from);
if (trigger === '@' && q.length >= 1) { if (trigger === '@' && q.length >= 1) {
const results = filterMentionItems(atPool, q.slice(1)); const results = filterMentionItems(atPoolRef.current, q.slice(1));
setMentionQuery(q.slice(1)); setMentionQuery(q.slice(1));
setMentionItems2(results); setMentionItems2(results);
setMentionIdx(0); setMentionIdx(0);
@ -533,7 +541,7 @@ export const IMEditor = forwardRef<IMEditorHandle, IMEditorProps>(function IMEdi
} }
} }
} else if (trigger === '#' && q.length >= 1) { } else if (trigger === '#' && q.length >= 1) {
const results = filterMentionItems(hashPool, q.slice(1)); const results = filterMentionItems(hashPoolRef.current, q.slice(1));
setMentionQuery(q.slice(1)); setMentionQuery(q.slice(1));
setMentionItems2(results); setMentionItems2(results);
setMentionIdx(0); setMentionIdx(0);
@ -548,7 +556,7 @@ export const IMEditor = forwardRef<IMEditorHandle, IMEditorProps>(function IMEdi
} }
} }
} else if (trigger === '/' && q.length >= 1) { } else if (trigger === '/' && q.length >= 1) {
const results = filterMentionItems(slashPool, q.slice(1)); const results = filterMentionItems(slashPoolRef.current, q.slice(1));
setMentionQuery(q.slice(1)); setMentionQuery(q.slice(1));
setMentionItems2(results); setMentionItems2(results);
setMentionIdx(0); setMentionIdx(0);