bdb5393835
Critical: - CORS: replace allow_any_origin + credentials with env-configured origins - XSS: escape HTML before dangerouslySetInnerHTML in search results - Path traversal: sanitize storage keys to reject ".." components - Auth missing: add Session requirement to git init/open/is-repo endpoints - Transaction: wrap issue cascade delete in DB transaction High: - Mutex poisoning: replace unwrap() with poison-recovering guards - Drop tokio::spawn: use runtime handle or fallback thread for lock release - Redis KEYS: replace with non-blocking SCAN for typing events - SSH panic: handle missing stdin/stdout/stderr gracefully - LFS auth: remove x-user-uid header injection vector, generate per-request tokens Medium: - Memory leak: remove Box::leak in provider normalization - Race conditions: query closed count directly instead of subtraction - Silent failures: add tracing::warn for AI tasks, room events, activity logs - Frontend nav: sync activeRoomId when initialRoomId prop changes - Duplicate nav: remove redundant setActiveRoom in delete handler - Callback conflict: skip undefined values in updateCallbacks merge - Stale closure: use wsClient state instead of wsClientRef.current in useMemo Low: - Captcha: validate captcha not empty before login submission - Broadcast capacity: reduce from 100K to 1000 - Error handling: add try/catch for removeMember and updateMemberRole - Loading state: show placeholder instead of null in RepositoryContextProvider - WebSocket: add heartbeat ping and jitter to reconnect backoff
70 lines
2.4 KiB
Rust
70 lines
2.4 KiB
Rust
use crate::AppService;
|
|
use crate::error::AppError;
|
|
use serde::{Deserialize, Serialize};
|
|
use session::Session;
|
|
#[derive(Debug, Clone, Serialize, Deserialize, utoipa::ToSchema)]
|
|
pub struct GitInitResponse {
|
|
pub path: String,
|
|
pub is_bare: bool,
|
|
}
|
|
#[derive(Debug, Clone, Deserialize, utoipa::ToSchema)]
|
|
pub struct GitInitRequest {
|
|
pub path: String,
|
|
#[serde(default)]
|
|
pub bare: bool,
|
|
#[serde(default)]
|
|
pub initial_branch: Option<String>,
|
|
}
|
|
impl AppService {
|
|
pub async fn git_init_bare(
|
|
&self,
|
|
request: GitInitRequest,
|
|
ctx: &Session,
|
|
) -> Result<GitInitResponse, AppError> {
|
|
let _user_uid = ctx.user().ok_or(AppError::Unauthorized)?;
|
|
let domain = git::GitDomain::init_bare(&request.path).map_err(AppError::from)?;
|
|
Ok(GitInitResponse {
|
|
path: domain.repo().path().to_string_lossy().to_string(),
|
|
is_bare: true,
|
|
})
|
|
}
|
|
|
|
pub async fn git_open(&self, path: String, ctx: &Session) -> Result<GitInitResponse, AppError> {
|
|
let _user_uid = ctx.user().ok_or(AppError::Unauthorized)?;
|
|
let domain = git::GitDomain::open(&path).map_err(AppError::from)?;
|
|
Ok(GitInitResponse {
|
|
path: domain.repo().path().to_string_lossy().to_string(),
|
|
is_bare: domain.repo().is_bare(),
|
|
})
|
|
}
|
|
|
|
pub async fn git_open_workdir(&self, path: String, ctx: &Session) -> Result<GitInitResponse, AppError> {
|
|
let _user_uid = ctx.user().ok_or(AppError::Unauthorized)?;
|
|
let domain = git::GitDomain::open_workdir(&path).map_err(AppError::from)?;
|
|
Ok(GitInitResponse {
|
|
path: domain.repo().path().to_string_lossy().to_string(),
|
|
is_bare: false,
|
|
})
|
|
}
|
|
|
|
pub async fn git_is_repo(&self, path: String, ctx: &Session) -> Result<bool, AppError> {
|
|
let _user_uid = ctx.user().ok_or(AppError::Unauthorized)?;
|
|
match git::GitDomain::open(&path) {
|
|
Ok(_) => Ok(true),
|
|
Err(git::GitError::NotFound(_)) => Ok(false),
|
|
Err(git::GitError::IoError(_)) => Ok(false),
|
|
Err(e) => Err(AppError::from(e)),
|
|
}
|
|
}
|
|
|
|
pub async fn git_repo_path(
|
|
&self,
|
|
namespace: String,
|
|
repo_name: String,
|
|
ctx: &Session,
|
|
) -> Result<String, AppError> {
|
|
let repo = self.utils_find_repo(namespace, repo_name, ctx).await?;
|
|
Ok(repo.storage_path)
|
|
}
|
|
}
|